Fix content type validation when charset is provided #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The content types matching should only take into account the type and subtype, not any of the content type parameters. Fixes aws#185.
jamesls
requested review from
dstufft,
stealthycoin,
JordonPhillips and
kyleknap
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
==========================================
+ Coverage 87.32% 87.35% +0.02%
==========================================
Files 19 19
Lines 1815 1819 +4
Branches 211 212 +1
==========================================
+ Hits 1585 1589 +4
Misses 178 178
Partials 52 52
Continue to review full report at Codecov.
|
stealthycoin
approved these changes
Apr 28, 2017
jamesls
added a commit
that referenced
this pull request
May 1, 2017
Merges #312 * content-header-fix: Fix content type validation when charset is provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The content types matching should only take into account the
type and subtype, not any of the content type parameters.
Content-Type grammar: https://tools.ietf.org/html/rfc7231#section-3.1.1.1
Fixes #185.