Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain the effect of Access-Control-Allow-Origin: '*' #300

Closed
wants to merge 1 commit into from
Closed

Explain the effect of Access-Control-Allow-Origin: '*' #300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,7 @@ Settings ``cors=True`` has similar behavior to enabling CORS
using the AWS Console. This includes:

* Injecting the ``Access-Control-Allow-Origin: *`` header to your
responses, including all error responses you can return.
responses, including all error responses you can return. A wildcard ``'*'`` indicates that any origin will be allowed to access the resource. Setting this value to your specific domain is highly recommended, for example ``Access-Control-Allow-Origin: api.my-domain.com``. Until this cors issue_ is resolved, you will have to manually modify this value within API Gateway.
* Automatically adding an ``OPTIONS`` method so support preflighting
requests.

Expand All @@ -739,10 +739,11 @@ There's a couple of things to keep in mind when enabling cors for a view:
* There's no support for customizing the CORS configuration.

The last two points will change in the future. See
`this issue
<https://github.com/awslabs/chalice/issues/70#issuecomment-248787037>`_
this cors issue_
for more information.

.. _issue: https://github.com/awslabs/chalice/issues/70#issuecomment-248787037


Tutorial: Policy Generation
===========================
Expand Down