Add port parameter to local command #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 70.46% (diff: 11.11%)@@ master #220 diff @@
==========================================
Files 12 12
Lines 1480 1483 +3
Methods 0 0
Messages 0 0
Branches 191 191
==========================================
Hits 1045 1045
- Misses 384 387 +3
Partials 51 51
|
|
+1 |
|
@gliptak Can you please add unit tests? |
|
@andriisoldatenko Would you offer a recommendation which unit test to |
|
Any guidance? Thanks |
|
Thanks for the pull request and sorry for the delay. I've gone ahead and added a test so we can get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check closely as my local dev environment is not fully running ...