-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multi value header responses #1214
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1214 +/- ##
==========================================
+ Coverage 96.04% 96.04% +<.01%
==========================================
Files 28 28
Lines 5229 5238 +9
Branches 668 670 +2
==========================================
+ Hits 5022 5031 +9
Misses 134 134
Partials 73 73
Continue to review full report at Codecov.
|
The other option here would be to overload the Thoughts? This case seems simpler than the last one (#1165) |
e1ba0d2
to
939724d
Compare
Are you referring to #1165? If so, I think that's a little different in the sense that we're not changing any existing behavior and just supporting a case we previously weren't (a list value in the headers dict). Given we're not messing around with types or anything, I think this is much safer. Plus, reading the doc page you linked, the interaction between My preference is to just make a list-value automatically work. What do others think? |
Yeah let's just make lists work because:
|
API Gateway added support for a multi-value header dictionary whcih can be returned. This commit adds support for it in Chalice.
939724d
to
bac9036
Compare
bac9036
to
2abf2f6
Compare
API Gateway added support for a multi-value header dictionary whcih can
be returned. This commit adds support for it in Chalice.
implements #1205
API Gateway docs: https://docs.aws.amazon.com/apigateway/latest/developerguide/set-up-lambda-proxy-integrations.html#api-gateway-simple-proxy-for-lambda-output-format