Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for stage-independent lambda function config #1162

Merged
merged 3 commits into from
Aug 9, 2019

Conversation

nkeyes
Copy link
Contributor

@nkeyes nkeyes commented Jul 7, 2019

Description of changes:
Allow for stage-independent lambda function config
You can now specify lambda config under the top-level key lambda_functions as well as in specific stages

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Jul 7, 2019

Codecov Report

Merging #1162 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1162      +/-   ##
==========================================
+ Coverage   95.98%   95.98%   +<.01%     
==========================================
  Files          28       28              
  Lines        5175     5176       +1     
  Branches      658      658              
==========================================
+ Hits         4967     4968       +1     
  Misses        135      135              
  Partials       73       73
Impacted Files Coverage Δ
chalice/config.py 95.8% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baba518...df8d38b. Read the comment docs.

Copy link
Member

@jamesls jamesls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, looks good to me. I'm just going to update the docs before merging.

@jamesls jamesls force-pushed the stage-independent-lambda-function-config branch from a439c66 to df8d38b Compare August 8, 2019 23:59
@jamesls jamesls merged commit df8d38b into aws:master Aug 9, 2019
jamesls added a commit that referenced this pull request Aug 9, 2019
PR #1162

* stage-independent-lambda-function-config:
  Add changelog for #1162
  Add docs for stage independent lambda functions
  allow for stage-independent lambda function config
studio3104 pushed a commit to studio3104/chalice that referenced this pull request Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants