Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local package installation #1047

Merged

Conversation

stealthycoin
Copy link
Contributor

When packaging the dependencies only the first local package would be
included in the final bundle. This change adds support for any number
of local directory links to be treated as buildable dependencies. Tests
were also added for the case of 1 or 2 local directory links specified
in the requirements.txt.

@codecov-io
Copy link

codecov-io commented Jan 14, 2019

Codecov Report

Merging #1047 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1047   +/-   ##
=======================================
  Coverage   95.47%   95.47%           
=======================================
  Files          27       27           
  Lines        4488     4488           
  Branches      563      563           
=======================================
  Hits         4285     4285           
  Misses        131      131           
  Partials       72       72
Impacted Files Coverage Δ
chalice/deploy/packager.py 95.88% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f20ec2...b67eaf0. Read the comment docs.

Copy link
Member

@jamesls jamesls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog please, but looks good.

When packaging the dependencies only the first local package would be
included in the final bundle. This change adds support for any number
of local directory links to be treated as buildable dependencies. Tests
were also added for the case of 1 or 2 local directory links specified
in the requirements.txt.
@stealthycoin stealthycoin force-pushed the support-multiple-local-dependencies branch from db42fb0 to b67eaf0 Compare January 14, 2019 18:43
@stealthycoin stealthycoin merged commit 8426d4c into aws:master Jan 14, 2019
@stealthycoin stealthycoin deleted the support-multiple-local-dependencies branch January 14, 2019 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants