Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

now project_dir always will be stored as absolute path in the context. #1037

Closed
wants to merge 3 commits into from
Closed

now project_dir always will be stored as absolute path in the context. #1037

wants to merge 3 commits into from

Conversation

igorborgest
Copy link
Contributor

Requested here: #940

Description of changes:
Now project_dir always will be stored as absolute path in the context. This will allow use absolute or relative paths in the --project-dir CLI parameter.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Jan 7, 2019

Codecov Report

Merging #1037 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1037      +/-   ##
=========================================
+ Coverage   95.47%   95.5%   +0.02%     
=========================================
  Files          27      27              
  Lines        4488    4490       +2     
  Branches      563     564       +1     
=========================================
+ Hits         4285    4288       +3     
  Misses        131     131              
+ Partials       72      71       -1
Impacted Files Coverage Δ
chalice/cli/__init__.py 87.87% <100%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbed9ca...2e440ab. Read the comment docs.

@igorborgest
Copy link
Contributor Author

I used the pytest.mark.parametrize feature to improve the code coverage. I think that increases the coverage in a elegant way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants