Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency packaging does not propagate errors from subprocess #500

Closed
stealthycoin opened this issue Aug 29, 2017 · 0 comments
Closed

Dependency packaging does not propagate errors from subprocess #500

stealthycoin opened this issue Aug 29, 2017 · 0 comments
Assignees
@stealthycoin
Labels
bug

Comments

@stealthycoin
Copy link
Contributor

During the pip download -r requirements.txt call that Chalice makes during packaging it does not properly propagate the error code from the subprocess up to Chalice so it doesn't ever error out if there was a failure.

Initial issue #497
@stealthycoin stealthycoin self-assigned this Aug 29, 2017
@stealthycoin stealthycoin mentioned this issue Aug 29, 2017
Closed
stealthycoin added a commit to stealthycoin/chalice that referenced this issue Aug 31, 2017
@stealthycoin
Fix error code propagation from subprocess pip
1416d6b 
Error codes were not returned which would result in pip failures not
cancelling the Chalice deploy process when they should. For example if
you provided a bad package name that pip failed to find the error would
be ignored and all the partial package would be deployed anyway.

Fixes aws#500
@stealthycoin stealthycoin mentioned this issue Aug 31, 2017
Merged
stealthycoin added a commit to stealthycoin/chalice that referenced this issue Sep 1, 2017
@stealthycoin
Fix error code propagation from subprocess pip
985a8a8 
Error codes were not returned which would result in pip failures not
cancelling the Chalice deploy process when they should. For example if
you provided a bad package name that pip failed to find the error would
be ignored and all the partial package would be deployed anyway.

Fixes aws#500
stealthycoin added a commit to stealthycoin/chalice that referenced this issue Sep 1, 2017
@stealthycoin
Fix error code propagation from subprocess pip
f46b05e 
Error codes were not returned which would result in pip failures not
cancelling the Chalice deploy process when they should. For example if
you provided a bad package name that pip failed to find the error would
be ignored and all the partial package would be deployed anyway.

Fixes aws#500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stealthycoin stealthycoin

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stealthycoin