-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK generation not handling URL path variables #498
Comments
Note: If I modify
to:
|
Thanks, this is a confirmed bug. I believe this regressed when we switched over to generating a swagger file internally. I think the What we generate "paths": {
"/hello/{name}": {
"get": {
"responses": {
"200": {
"description": "200 response",
"schema": {
"$ref": "#/definitions/Empty"
}
}
},
"x-amazon-apigateway-integration": {
"contentHandling": "CONVERT_TO_TEXT",
"responses": {
"default": {
"statusCode": "200"
}
},
"parameters": [
{
"required": true,
"type": "string",
"name": "name",
"in": "path"
}
], What we actually need to generate
Note the Thanks for reporting we'll get this fixed. |
This should not be in the x-amazon-apigateway-integration key but instead in the key for the http method which is up one level. Fixes aws#498
When trying to recreate the example in the docs, the generated javascript GET methods like
apigClient.helloNameGet({name: 'jimmy'})
that are supposed to use parameters to construct the path don't seem to work. When using chrome inspect it looks like it's not adding "jimmy" to the URL.When constructing an example like
@app.route('/{name}/hello')
then the javascript makes an api call to<BASE>/api//hello
.The text was updated successfully, but these errors were encountered: