Skip to content

Commit

Permalink
fix large file, mulitipart upload to s3 (#4141)
Browse files Browse the repository at this point in the history
* fix large file, mulitipart upload to s3

* add changelog

Co-authored-by: Emile Indik <[email protected]>
  • Loading branch information
AllanZhengYP and emileindik authored Jun 29, 2022
1 parent b0fd315 commit b6d357e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changes/next-release/bugfix-ManagedUpload-91473b2e.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"type": "bugfix",
"category": "ManagedUpload",
"description": "fix MalformedXML error for relatively large file via managed upload"
}
2 changes: 1 addition & 1 deletion lib/s3/managed_upload.js
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ AWS.S3.ManagedUpload = AWS.util.inherit({
if (self.completeInfo[partNumber] && self.completeInfo[partNumber].ETag !== null) return null;
partInfo.ETag = data.ETag;
self.doneParts++;
if (self.isDoneChunking && self.doneParts === self.numParts) {
if (self.isDoneChunking && self.doneParts === self.totalPartNumbers) {
self.finishMultiPart();
} else {
self.fillQueue.call(self);
Expand Down

0 comments on commit b6d357e

Please sign in to comment.