Make the 'version' field of serverless S3Location optional #67
Conversation
The hand-written docs disagree with our copy of the model.
|
Build failure is because of upgrade to the 'superchain' Docker image |
| @@ -194,7 +194,7 @@ | |||
| }, | |||
| "Version": { | |||
| "Documentation": "https://github.com/awslabs/serverless-application-model/blob/master/versions/2016-10-31.md#awsserverlessfunction", | |||
| "Required": true, | |||
| "Required": false, | |||
There was a problem hiding this comment.
Should we bring in a new version of the SAM spec? Is it up-to-date there?
There was a problem hiding this comment.
There was a problem hiding this comment.
Aight thanks. Didn't help though:
https://github.com/awslabs/goformation/blob/master/generate/sam-2016-10-31.json#L197
There was a problem hiding this comment.
There was a problem hiding this comment.
The main problem here is that while CloudFormation has a published machine generated specification, SAM currently does not. The one in the Goformation repository was manually generated, and has no mechanism to keep it up to date. I suggest reaching out to sanathkr@ on the SAM team.
|
I forgot where we get this :( |
The hand-written docs disagree with our copy of the model.
This fixes #66.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.