Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HeadNode fails to configure due to ansible change. on_head_node_configured.sh fails as ansible has deprecated ansible.builtin.include #238

Closed
gwolski opened this issue Jun 11, 2024 · 2 comments · Fixed by #241

Comments

@gwolski
Copy link

gwolski commented Jun 11, 2024

Using latest version of aws-eda-slurm-cluster as of May 15.

Headnode fails to configure. cloud init fails. Reproduce by deploying new cluster with latest ansible

Tracked things down so far to the shell script on_head_node_configured.sh. Error message is:

<13>Jun 10 16:48:18 on_head_node_configured.sh: TASK [all : Create /var/lib/cloud/scripts/per-boot/90_mount_ssds.bash] *********
<13>Jun 10 16:48:18 on_head_node_configured.sh: ok: [local]
<13>Jun 10 16:48:18 on_head_node_configured.sh:
<13>Jun 10 16:48:18 on_head_node_configured.sh: TASK [all : Execute /var/lib/cloud/scripts/per-boot/90_mount_ssds.bash] ********
<13>Jun 10 16:48:18 on_head_node_configured.sh: ok: [local]
<13>Jun 10 16:48:18 on_head_node_configured.sh:
<13>Jun 10 16:48:18 on_head_node_configured.sh: TASK [all : Give /tmp write permissions] ***************************************
<13>Jun 10 16:48:18 on_head_node_configured.sh: ok: [local]
<13>Jun 10 16:48:18 on_head_node_configured.sh: ERROR! [DEPRECATED]: ansible.builtin.include has been removed. Use include_tasks or import_tasks instead. This feature was removed from ansible-core in a release after 2023-05-16. Please update your playbooks.
<13>Jun 10 16:48:18 on_head_node_configured.sh: + on_exit
<13>Jun 10 16:48:18 on_head_node_configured.sh: + rc=1
<13>Jun 10 16:48:18 on_head_node_configured.sh: + set +e
<13>Jun 10 16:48:18 on_head_node_configured.sh: + [[ 1 -ne 0 ]]
<13>Jun 10 16:48:18 on_head_node_configured.sh: + [[ : != : ]]

include is used in
/opt/slurm/config/ansible/playbooks/roles/ParallelClusterHeadNode/tasks/main.yml

@gwolski
Copy link
Author

gwolski commented Jun 11, 2024

Changing tasks/main.yml to call ansible.builtin.import_tasks allows the on_head_node_configured.sh to run.
Here is the updated tasks/main.yml. I do not know enough about the replacement tasks to be 100% sure this is the best/right:


  • { ansible.builtin.import_tasks: config-users-groups.yml, tags: users-groups }
  • { ansible.builtin.import_tasks: config-high-throughput.yml, tags: high-throughput }
  • { ansible.builtin.import_tasks: config-submitter-access.yml, tags: submitter }
  • { ansible.builtin.import_tasks: config-sshd.yml, tags: sshd }
  • { ansible.builtin.import_tasks: config-slurmrestd.yml, tags: slurmrestd }
  • { ansible.builtin.import_tasks: config-licenses.yml, tags: licenses }
  • { ansible.builtin.import_tasks: config-slurmdb-accounts.yml, tags: accounts }

Will attempt to build a new cluster.

@gwolski
Copy link
Author

gwolski commented Jun 11, 2024

New cluster is working, build completed cleanly. Please do not trust my selection of ansible import_tasks as replacement for original "include" command.

cartalla added a commit that referenced this issue Jun 27, 2024
Use snake case instead of camel cases. Ansible naming conventions recommends
only using lower-case alphanumeric variable names with underscores.

Replace include with include_tasks.

Resolves #238
cartalla added a commit that referenced this issue Jun 27, 2024
Replace include with include_tasks.

Resolves #238

Resolve ansible-lint warnings and errors

Use snake case instead of camel cases. Ansible naming conventions recommends
only using lower-case alphanumeric variable names with underscores.

Support ParallelCluster 3.9.2.

Resolves #236

Add support for ParallelCluster 3.9.3

Resolves #240

Fix filename in documentation

Update the file where the Licenses are configured if you aren't using the slurmdb.

Resolves #239
cartalla added a commit that referenced this issue Jun 27, 2024
Replace include with include_tasks.

Resolves #238

Resolve ansible-lint warnings and errors

Use snake case instead of camel cases. Ansible naming conventions recommends
only using lower-case alphanumeric variable names with underscores.

Support ParallelCluster 3.9.2.

Resolves #236

Add support for ParallelCluster 3.9.3

Resolves #240

Fix filename in documentation

Update the file where the Licenses are configured if you aren't using the slurmdb.

Resolves #239
cartalla added a commit that referenced this issue Jun 27, 2024
Replace include with include_tasks.

Resolves #238

Resolve ansible-lint warnings and errors

Use snake case instead of camel cases. Ansible naming conventions recommends
only using lower-case alphanumeric variable names with underscores.

Support ParallelCluster 3.9.2.

Resolves #236

Add support for ParallelCluster 3.9.3

Resolves #240

Fix filename in documentation

Update the file where the Licenses are configured if you aren't using the slurmdb.

Resolves #239
cartalla added a commit that referenced this issue Jun 27, 2024
Replace include with include_tasks.

Resolves #238

Resolve ansible-lint warnings and errors

Use snake case instead of camel cases. Ansible naming conventions recommends
only using lower-case alphanumeric variable names with underscores.

Support ParallelCluster 3.9.2.

Resolves #236

Add support for ParallelCluster 3.9.3

Resolves #240

Fix filename in documentation

Update the file where the Licenses are configured if you aren't using the slurmdb.

Resolves #239
cartalla added a commit that referenced this issue Jun 27, 2024
Replace include with include_tasks.

Resolves #238

Resolve ansible-lint warnings and errors

Use snake case instead of camel cases. Ansible naming conventions recommends
only using lower-case alphanumeric variable names with underscores.

Support ParallelCluster 3.9.2.

Resolves #236

Add support for ParallelCluster 3.9.3

Resolves #240

Fix filename in documentation

Update the file where the Licenses are configured if you aren't using the slurmdb.

Resolves #239
cartalla added a commit that referenced this issue Jun 27, 2024
Replace include with include_tasks.

Resolves #238

Resolve ansible-lint warnings and errors

Use snake case instead of camel cases. Ansible naming conventions recommends
only using lower-case alphanumeric variable names with underscores.

Support ParallelCluster 3.9.2.

Resolves #236

Add support for ParallelCluster 3.9.3

Resolves #240

Fix filename in documentation

Update the file where the Licenses are configured if you aren't using the slurmdb.

Resolves #239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant