Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Delete local build files that can contain tokens or stale values #216

Closed
cartalla opened this issue Apr 2, 2024 · 0 comments · Fixed by #217
Closed

[BUG] Delete local build files that can contain tokens or stale values #216

cartalla opened this issue Apr 2, 2024 · 0 comments · Fixed by #217
Assignees
@cartalla

Comments

@cartalla
Copy link
Contributor

cartalla commented Apr 2, 2024

Describe the bug

When I fixed #184 I didn't delete the old code that created local build-files.

This can lead to confusion if people try to use them instead of the ones that are created on the head node that will
always have the correct values.

Delete the old code since it is incorrect and not needed.

Make sure that the documentation makes it clear that the build files are on the head node.
@cartalla cartalla self-assigned this Apr 2, 2024
cartalla added a commit that referenced this issue Apr 2, 2024
@cartalla
Remove creation of local AMI build-files
34a6ec6 
They are now generated in a lambda and downloaded to the head node.

Related to #184.

Resolves #216
cartalla added a commit that referenced this issue Apr 2, 2024
@cartalla
Remove creation of local AMI build-files
e6ec919 
They are now generated in a lambda and downloaded to the head node.

Related to #184.

Resolves #216
@cartalla cartalla mentioned this issue Apr 2, 2024
Merged
@cartalla cartalla linked a pull request Apr 2, 2024 that will close this issue
Remove creation of local AMI build-files #217
Merged
cartalla added a commit that referenced this issue Apr 2, 2024
@cartalla
Remove creation of local AMI build-files
3ee6578 
They are now generated in a lambda and downloaded to the head node.

Related to #184.

Resolves #216
cartalla added a commit that referenced this issue Apr 2, 2024
@cartalla
Remove creation of local AMI build-files (#217)
2e334c2 
They are now generated in a lambda and downloaded to the head node.

Related to #184.

Resolves #216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cartalla cartalla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove creation of local AMI build-files aws-samples/aws-eda-slurm-cluster
1 participant
@cartalla