Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Changing controller instance type doesn't cause cluster to be update #202

Closed
cartalla opened this issue Feb 5, 2024 · 1 comment · Fixed by #205
Closed

[BUG] Changing controller instance type doesn't cause cluster to be update #202

cartalla opened this issue Feb 5, 2024 · 1 comment · Fixed by #205
Assignees
@cartalla

Comments

@cartalla
Copy link
Contributor

cartalla commented Feb 5, 2024

Describe the bug
I changed /slurm/SlurmCtl/instance_type and updated the config stack and CDK doesn't detect any stack changes.
@cartalla
Copy link
Contributor Author

cartalla commented Feb 5, 2024

This is because the config file is now a jinja template that is stored in s3 and a custom resource expands the template and store the resolved template in s3. So the stack now doesn't see the parallel cluster config as an input to anything, just the path to the s3 object.

Update the custom resource to output the hash of config file and put that as an input the the parallelcluster custom resource.

@cartalla cartalla self-assigned this Feb 5, 2024
cartalla added a commit that referenced this issue Feb 26, 2024
@cartalla
Update cluster when config file changes
aad57a7 
Move the code that expands the config file template to a separate lambda and
custom resource so we can get its sha512 hash and use it to determine when
the cluster needs to be updated.

Resolves #202
@cartalla cartalla mentioned this issue Feb 26, 2024
Merged
@cartalla cartalla linked a pull request Feb 26, 2024 that will close this issue
Update cluster when config file changes #205
Merged
cartalla added a commit that referenced this issue Feb 26, 2024
@cartalla
Update cluster when config file changes
c2d8942 
Move the code that expands the config file template to a separate lambda and
custom resource so we can get its sha512 hash and use it to determine when
the cluster needs to be updated.

Resolves #202
cartalla added a commit that referenced this issue Feb 26, 2024
@cartalla
Update cluster when config file changes (#205)
a8b6555 
Move the code that expands the config file template to a separate lambda and
custom resource so we can get its sha512 hash and use it to determine when
the cluster needs to be updated.

Resolves #202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cartalla cartalla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update cluster when config file changes aws-samples/aws-eda-slurm-cluster
1 participant
@cartalla