Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Deployment fails if RESEnvironmentName not configured #189

Closed
cartalla opened this issue Jan 11, 2024 · 0 comments · Fixed by #192
Closed

[BUG] Deployment fails if RESEnvironmentName not configured #189

cartalla opened this issue Jan 11, 2024 · 0 comments · Fixed by #192
Assignees
@cartalla

Comments

@cartalla
Copy link
Contributor

Describe the bug

Deployment failed when I tried to deploy into a bare VPC and RESEnvironmentName wasn't set.
I got the following stack trace.

Traceback (most recent call last):
  File "app.py", line 32, in <module>
    termination_protection = True,
  File "/workplace/cartalla/github/aws-eda-slurm-cluster/source/.venv/lib64/python3.7/site-packages/jsii/_runtime.py", line 118, in __call__
    inst = super(JSIIMeta, cast(JSIIMeta, cls)).__call__(*args, **kwargs)
  File "/workplace/cartalla/github/aws-eda-slurm-cluster/source/cdk/cdk_slurm_stack.py", line 132, in __init__
    self.create_parallel_cluster_assets()
  File "/workplace/cartalla/github/aws-eda-slurm-cluster/source/cdk/cdk_slurm_stack.py", line 577, in create_parallel_cluster_assets
    string_value = self.configure_cluster_manager_sns_topic.topic_arn
AttributeError: 'CdkSlurmStack' object has no attribute 'configure_cluster_manager_sns_topic'

Additional context
Add any other context about the problem here.
@cartalla cartalla self-assigned this Jan 11, 2024
cartalla added a commit that referenced this issue Jan 19, 2024
@cartalla
Fix bug where RESEnvironmentName is not set
ff7a829 
Handle case where ParallelClusterConfig DatabaseStackName isn't ready yet.

Resolves #190

Don't create self.configure_cluster_manager_sns_topic_arn_parameter if
RESEnvironmentName not configured.

Resolves #189
@cartalla cartalla mentioned this issue Jan 19, 2024
Merged
@cartalla cartalla linked a pull request Jan 19, 2024 that will close this issue
Fix bug where RESEnvironmentName is not set #192
Merged
cartalla added a commit that referenced this issue Jan 19, 2024
@cartalla
Fix bug when RESEnvironmentName is not set
5e07d3e 
Don't create self.configure_cluster_manager_sns_topic_arn_parameter if
RESEnvironmentName not configured.

Rename variables and lambdas for RES related configuration to include "Res" for clarity.

Resolves #189

Handle case where ParallelClusterConfig DatabaseStackName isn't ready yet.

Resolves #190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cartalla cartalla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug where RESEnvironmentName is not set aws-samples/aws-eda-slurm-cluster
1 participant
@cartalla