fix: Attempt to use created log group for AWS for FluentBit before falling back to an externally created log group name #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelhoisko
changed the title
enable_aws_for_fluentbit = true use the name of the created log group in the fluentbit config
bryantbiggs
reviewed
Oct 29, 2024
bryantbiggs
changed the title
enable_aws_for_fluentbit = true use the name of the created log group in the fluentbit config
bryantbiggs
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Change the
cloudWatchLogs.logGroupNamefluentbit helm chart value to match the created log group. Might not work if the log group doesn't exist, haven't tested this yet etc.Motivation
More
pre-commit run -awith this PRFor Moderators
Additional Notes
I saw the this closed PR also fixed the issue and also works when the log group doesn't exist.