Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add random entryopy to CloudFormation stack name for when module used multiple times on the same cluster #425

Merged
merged 1 commit into from
Oct 27, 2024
Merged

fix: Add random entryopy to CloudFormation stack name for when module used multiple times on the same cluster #425

merged 1 commit into from
Oct 27, 2024

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

  • Add random entryopy to CloudFormation stack name for when module used multiple times on the same cluster

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs marked this pull request as ready for review October 27, 2024 00:22
@bryantbiggs bryantbiggs requested a review from a team as a code owner October 27, 2024 00:22
@bryantbiggs bryantbiggs merged commit c4379e9 into main Oct 27, 2024
6 checks passed
@bryantbiggs bryantbiggs deleted the fix/telemtry-unique branch October 27, 2024 01:42
mariomcosta added a commit to mariomcosta/terraform-aws-eks-blueprints-addons that referenced this pull request Oct 28, 2024
@mariomcosta
bump hashicorp/random provider to require v3.6
8cbb5f5 
It's due to this error:

The provider hashicorp/random does not support resource type "random_bytes"

PR that introduced this scenario:
aws-ia#425

Randon provider documentation:
https://registry.terraform.io/providers/hashicorp/random/3.6.0/docs
This was referenced Oct 28, 2024
Open
Closed
Merged
@gugu
Copy link

gugu commented Oct 29, 2024

Is there any way to opt out of this? It adds unneded complexity to our terraform plan

@Roberdvs
Copy link

Roberdvs commented Oct 31, 2024 •
edited
Loading

Is there any way to opt out of this? It adds unneded complexity to our terraform plan

You can opt-out of the creation of the CloudFormation resource by passing observability_tag = null to the module but unfortunately, due to how Terraform works, it will still need to initialize the random provider since it's now part of the module's required_providers (edit: well, the random_bytes resource is not being conditionally created so the provider would be needed anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bryantbiggs @gugu @Roberdvs @askulkarni2