Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(karpenter): Pin to previous working chart version #366

Closed
wants to merge 1 commit into from

Conversation

benjefferies
Copy link

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

If already installed the upgrade, you may get an issue.

failed to get API group resources: unable to retrieve the complete list of server APIs: karpenter.sh/v1beta1: the server could not find the requested resource

To fix uninstall karpenter and reapply terraform

helm uninstall karpenter -n karpenter

Motivation

Fixes #365

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

If already installed the upgrade, you may get an issue.

```
failed to get API group resources: unable to retrieve the complete list of server APIs: karpenter.sh/v1beta1: the server could not find the requested resource
```

To fix uninstall karpenter and reapply terraform
```bash
helm uninstall karpenter -n karpenter
```

Fixes aws-ia#365
@benjefferies benjefferies requested a review from a team as a code owner March 8, 2024 11:07
@@ -3015,7 +3015,7 @@ module "karpenter" {
namespace = local.karpenter_namespace
create_namespace = try(var.karpenter.create_namespace, true)
chart = try(var.karpenter.chart, "karpenter")
chart_version = try(var.karpenter.chart_version, "0.35.0")
chart_version = try(var.karpenter.chart_version, "v0.32.1")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the downgrade?
v0.35.1 is out

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this issue still exists and needs fixing aws/karpenter-provider-aws#5415

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A workaround could be pinning the image tag to the correct one instead perhaps but I haven't tested that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, but I am unable to reproduce the error - the default version is just that, a default. we encourage users to specify the version in order to have better control over which version is used and when that changes. for now, I would say set the v0.32.1 version in your configuration if that what puts things back into a healthy state. Closing this out for now though

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting you couldn't reproduce with the default values. Did you test this with an upgrade or in a fresh install?

I'm happy for it to be closed if no one else is seeing the issue, perhaps it's related to our deployment but we're installing karpenter with mostly default values including the image and helm chart

@askulkarni2 askulkarni2 added upstream Dependency on an upstream related issue and removed upstream Dependency on an upstream related issue labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest karpenter upgrade causes crash due to list/watch configmap forbidden
4 participants