Feature/441 #446
Merged
Feature/441 #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned …eters. This also stops the CLI from always overwriting the params and instead only overwrites the parameters that it must
|
This was rebased incorrectly. Rebasing, testing, and re-committing. |
mikeparisstuff
force-pushed
the
feature/441
branch
from
0ee3eaa to
c81a379
Compare
|
Is the issue #441 fixed? |
|
@mikeparisstuff are we documenting this somewhere? |
kaustavghosh06
approved these changes
Jan 3, 2019
|
See PR for updated documentation here aws-amplify/docs#352. |
|
@mikeparisstuff Can you please update the multienv branch with this change as well? |
|
Is there an example of this ? |
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#441
Description of changes:
This adds support for custom API key expiration dates as well as supports auto-refreshing API keys on push. This also changes CLI behaviour in that now it now merges instead of overwriting the parameters.json file. This also adds a new parameter named APIKeyExpirationEpoch that can be used to tweak API keys as follows:
Resets the API Key to expire 1 week after the next
amplify pushDo not create an API key
Set a custom API key
would make the key expire Thursday, December 13, 2018 11:57:08 PM GMT.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.