libvirt-vm:Add support for cmdline parameter for --boot #3977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, kernel_args is not present in the output of "virt-install --boot help" as "--boot cmdline=%s" is the recommended way of passing kernel command line parameters. As a result, the import/install test is failiing since kernel and initrd parameter is being passed without kernel_args But --boot option supports both kernel_args and cmdline parameter for passing kernel arguments to the guest, i.e, --boot kernel=<vmlinuz>,initrd=<initrd>,cmdline=<kernel -cmdline> (or) --boot kernel=<vmlinuz>,initrd=<initrd>,kernel_args= <kernel-cmdline> This patch adds support of reading both cmdline and kernel_args parameter and passes whichever is available from config to the virt-install --boot option Signed-off-by: Misbah Anjum N <[email protected]>
ExplanationThis particular piece of code checks the presence of "kernel_args" parameter in the output of But the output of This is because, "cmdline" is the recommended way of passing the kernel command line parameters |
|
Config file Before patchkernel_args is not passed in --boot After patchkernel_args is being passed in --boot |
|
Please check the after patch output and confirm. |
The following is the updated output after patch Pointing to the specific line where |
harihare
reviewed
Aug 26, 2024
| @@ -986,6 +986,8 @@ def add_kernel( | |||
| result += "initrd=%s," % initrd_path | |||
| if has_sub_option("boot", "kernel_args") and kernel_args: | |||
| result += 'kernel_args="%s",' % kernel_args | |||
There was a problem hiding this comment.
Now that kernel_args is not part of virt_install shall we remove the check.
There was a problem hiding this comment.
@harihare
I kept that for people still using the older virt-install tool which has kernel_args parameter listed in virt-install --boot help
If that is not required, then I can remove that check
|
@clebergnu can you please help us to trigger CI for this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libvirt-vm: Add support for cmdline parameter for --boot
Currently, kernel_args is not present in the output of "virt-install --boot help" as "--boot cmdline=%s" is the recommended way of passing kernel command line parameters. As a result, the import/install test is failiing since kernel and initrd parameter is being passed without kernel_args
But --boot option supports both kernel_args and cmdline parameter for passing kernel arguments to the guest, i.e,
--boot kernel=<vmlinuz>,initrd=<initrd>,cmdline=<kernel-cmdline>(recommended way)(or)
--boot kernel=<vmlinuz>,initrd=<initrd>,kernel_args= <kernel-cmdline>This patch adds support of reading both cmdline and kernel_args parameter and passes whichever is available from config to the virt-install --boot option
Signed-off-by: Misbah Anjum N [email protected]