Replaced bag.isOpen() by checking bag filename #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think there would be value on making this change conditionally compiled based on ROS version and submitting upstream? |
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0"?> | |||
| <package format="2"> | |||
| <name>rosbag_snapshot</name> | |||
| <version>1.0.3</version> | |||
| <version>1.1.0</version> | |||
There was a problem hiding this comment.
I'd recommend updating the patch version instead of minor so that we have an easier time incorporating upstream updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no bag::isOpen interface in ros kinetic version of rosbag. Replaced the isOpen in rosbag_snapshot with checking the bag filename to make rosbag_snapshot compatible with ros kinetic. The open and close API of bag file are paired with assign and empty the filename of the bag file, please refer to source file here