Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the capability to work with non sim time in timekeeper #106

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sees1
Copy link

@sees1 sees1 commented Mar 14, 2024

No description provided.

@josephduchesne
Copy link
Member

josephduchesne commented Mar 15, 2024

Two concerns:

  • Turning off sim time might muck up the simulation loop due to the real clock running faster than the simulation can keep up. That might be ok, but maybe we should have a GetTimeDelta() method in TimeKeeper to get the duration between the last simulation loop and the current one, so that physics updates at a somewhat steady rate, even if some simulation loops take too long. As an example, I typically run the simulation loop at 200Hz, but the lidar plugin takes more than 1/200th of a second to execute on some PCs, resulting in a somewhat bumpy time progression. With sim time controlled by flatland this will result in Flatland progressing sim time unevenly, but within that sim time things will be normal. I believe all the plugins and update methods take a time delta float for their updates, but Flatland Server should populate this with the real time delta. This would also result in plugins not updating at their full data rate if the CPU was too busy.
  • Should flatland stop publishing /clock when sim time is disabled? I'm not sure, but I suspect so.

@sees1
Copy link
Author

sees1 commented May 17, 2024

Sorry for late. I'm little busy now, but i wan't to fix this problem, if it relevant, maybe in June?

@sees1
Copy link
Author

sees1 commented Jun 24, 2024

Make some notes about topic, can you check? @josephduchesne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants