Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use base SHA instead of base branch since the base branch #2

Merged
merged 8 commits into from
Dec 7, 2023

Conversation

jainankit
Copy link

@jainankit jainankit commented Dec 7, 2023

A PR could be using a stale base SHA. When calculating the affected targets, we should use the diff from base SHA to the head SHA. Since GH does not provide base SHA directly in the workflow action, make an API call to get the results.

@jainankit jainankit changed the title get base sha Use base SHA instead of base branch since the base branch Dec 7, 2023
@aviator-co aviator-co deleted a comment Dec 7, 2023
@@ -16,12 +16,22 @@ jobs:
node-version: '18'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot comment on the exact line, but on line 13, add

with:
  filter: 'blob:none'
  depth: 0

Copy link

aviator-app bot commented Dec 7, 2023

Skipping bot pull request creation because the queue is empty and this pull request is up to date with master.

@aviator-co aviator-co deleted a comment Dec 7, 2023
@aviator-co aviator-co deleted a comment from aviator-app bot Dec 7, 2023
@jainankit jainankit merged commit c9cdc9d into master Dec 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants