wip: add squash command #492
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
Brookke
commented
Dec 13, 2024
| return errors.New("current branch does not exist in the database") | ||
| } | ||
|
|
||
| // Could this be abstracted into a helper function? |
There was a problem hiding this comment.
I think this would be useful as a generic repo command. Lmk what you think
Brookke
commented
Dec 13, 2024
| return err | ||
| } | ||
|
|
||
| // What should the output be? |
There was a problem hiding this comment.
Should there be any output? maybe its fine without
Brookke
commented
Dec 13, 2024
| } | ||
|
|
||
| // What should the output be? | ||
| // Should a sync be triggered? |
There was a problem hiding this comment.
should I be running something like runPostCommitRestack here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress, opening for input on the open questions I have around output. Maybe this is fine as is...