Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #409 - WIP #451

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Issue #409 - WIP #451

wants to merge 4 commits into from

Conversation

Chafid
Copy link

@Chafid Chafid commented Nov 7, 2024

This is for handling the issue raised in #409.
Interactive menu has been added but restack still not working properly yet. Putting this as WIP

@Chafid Chafid requested a review from a team as a code owner November 7, 2024 02:20
Copy link
Contributor

aviator-app bot commented Nov 7, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@draftcode
Copy link
Contributor

I think that there's a bit of misunderstanding. All you need would be add an interactive option to RebaseOpts at

, and run git rebase interactively so that users can get a chance to squash.

@Chafid
Copy link
Author

Chafid commented Nov 10, 2024

Ok, I'm working on this


if opts.Interactive {
args = append(args, "-i")
args = append(args, "master")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need this. You should just add "-i" and run in interactive. Other args are added in other parts of the code.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it. I've pushed the changes, but I still have issue with the text editor. Seems like the fancy text that show up during non interactive is still showing up during interactive session. I've sent you the image on discord

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. I think you would need to change this to use https://pkg.go.dev/github.com/charmbracelet/bubbletea#Exec or https://pkg.go.dev/github.com/charmbracelet/bubbletea#ExecProcess. Bubbletea tries to control the tty, so we should stop it while executing another process.

Copy link
Contributor

aviator-app bot commented Nov 21, 2024

🔃 FlexReview Status

Warning

  • This PR modifies 297 lines, which is larger than the Review SLO threshold.

This might slow down the review process. If possible, split the PR into smaller ones

Owner: aviator-co/engineering (expertise assignment)
Review SLO: 7 business hours if PR size is <= 200 LOC for the first response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants