-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #409 - WIP #451
base: master
Are you sure you want to change the base?
Issue #409 - WIP #451
Conversation
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
I think that there's a bit of misunderstanding. All you need would be add an interactive option to RebaseOpts at av/internal/sequencer/sequencer.go Line 202 in ed184fe
|
Ok, I'm working on this |
internal/git/rebase.go
Outdated
|
||
if opts.Interactive { | ||
args = append(args, "-i") | ||
args = append(args, "master") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need this. You should just add "-i" and run in interactive. Other args are added in other parts of the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it. I've pushed the changes, but I still have issue with the text editor. Seems like the fancy text that show up during non interactive is still showing up during interactive session. I've sent you the image on discord
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. I think you would need to change this to use https://pkg.go.dev/github.com/charmbracelet/bubbletea#Exec or https://pkg.go.dev/github.com/charmbracelet/bubbletea#ExecProcess. Bubbletea tries to control the tty, so we should stop it while executing another process.
🔃 FlexReview StatusWarning
This might slow down the review process. If possible, split the PR into smaller ones Owner: |
This is for handling the issue raised in #409.
Interactive menu has been added but restack still not working properly yet. Putting this as WIP