Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check av's state file and REBASE_HEAD to prevent conflict #410

Closed
wants to merge 2 commits into from

Conversation

Konboi
Copy link
Contributor

@Konboi Konboi commented Aug 30, 2024

Addressed #388

Copy link
Contributor

aviator-app bot commented Aug 30, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was closed without merging. If you still want to merge this PR, re-open it.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@Konboi Konboi changed the title Issue 388 Check av's state file and REBASE_HEAD to prevent conflict Aug 30, 2024
"regexp"
"strings"

"github.com/sirupsen/logrus"
)

// ref: https://git-scm.com/docs/git-rev-parse#Documentation/git-rev-parse.txt-codeREBASEHEADcode
const REBASE_STATE_FILE = "REBASE_HEAD"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other places, REBASE_HEAD is defined as string directly.
Should I align with that here as well? It means that I shouldn't define this string as const?

@Konboi Konboi closed this Oct 14, 2024
@Konboi Konboi deleted the issue-388 branch October 14, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant