Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect the branch structure in a more robust way #384

Closed
wants to merge 1 commit into from

Conversation

draftcode
Copy link
Contributor

@draftcode draftcode commented Aug 6, 2024

This should address the issue where the stack adopt command fails when
it's invoked at the trunk branch. (#363)

Based on the feedbacks, it seems that the commit traversal is way slower
than expected. Try to be a bit more conservative when to traverse the
commits.

Copy link
Contributor

aviator-app bot commented Aug 6, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

Stack

  1. 👉 Detect the branch structure in a more robust way #384 👈 (this pr)

See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link
Contributor

aviator-app bot commented Aug 6, 2024

FlexReview Summary

Based on the code complexity and the author's expertise score, these are the suggested reviewers:

  • @jainankit (current review load: 1)
  • @alex-aviator (current review load: 1)

See the list of alternate reviewers in the detailed breakdown below.

Detailed Breakdown Author’s expertise score for the modified files:
  • cmd/av/stack_adopt.go (1.00)
  • cmd/av/stack_tree.go (1.00)
  • demos/stack_adopt/stack_adopt_no_root.mp4 (1.00)
  • demos/stack_adopt/stack_adopt_no_root.tape (1.00)
  • demos/stack_adopt/stack_adopt_with_stack_root.mp4 (1.00)
  • docs/av-stack-adopt.1.md (1.00)
  • e2e_tests/stack_adopt_test.go (1.00)
  • internal/git/git.go (1.00)
  • internal/reorder/plan.go (1.00)
  • internal/treedetector/detector.go (1.00)
  • internal/treedetector/util.go (1.00)
Files Reviewers
cmd/av/stack_adopt.go †,
cmd/av/stack_tree.go †,
docs/av-stack-adopt.1.md †,
internal/git/git.go †,
internal/reorder/plan.go †,
internal/treedetector/detector.go †,
internal/treedetector/util.go
@jainankit (score: 0.73, current review load: 1)
cmd/av/stack_adopt.go †,
demos/stack_adopt/stack_adopt_no_root.mp4 †,
demos/stack_adopt/stack_adopt_no_root.tape †,
demos/stack_adopt/stack_adopt_with_stack_root.mp4 †,
e2e_tests/stack_adopt_test.go †,
internal/git/git.go
@alex-aviator (score: 0.26, current review load: 1)

† Indicates that the file doesn't need an expert review. (?)

See full breakdown of the reviewers on the Aviator webapp.

@aviator-app aviator-app bot added the blocked label Aug 7, 2024
Copy link
Contributor

aviator-app bot commented Aug 7, 2024

This pull request failed to merge: top queued PR in the stack failed to merge. Once the issues are resolved, remove the blocked label and re-queue the pull request. Note that the pull request will be automatically re-queued if it has the mergequeue label.

This should address the issue where the stack adopt command fails when
it's invoked at the trunk branch. (#363)

Based on the feedbacks, it seems that the commit traversal is way slower
than expected. Try to be a bit more conservative when to traverse the
commits.
@draftcode draftcode force-pushed the fix_adopt_discovery branch from c281580 to f3d9f76 Compare August 7, 2024 23:00
@draftcode draftcode removed the blocked label Aug 7, 2024
@aviator-app aviator-app bot closed this in 0d3ef28 Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants