Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check if user is on trunk and prompt to sync all instead #366

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

Brookke
Copy link
Contributor

@Brookke Brookke commented Jul 24, 2024

addresses: #363

image

Copy link
Contributor

aviator-app bot commented Jul 24, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@@ -236,8 +237,35 @@ func (vm *stackSyncViewModel) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
vm.pruningBranches = false
return vm, tea.Quit

case promptUserShouldSyncAllMsg:
vm.syncAllPrompt = uiutils.NewPromptModel("You are on the trunk, do you want to sync all stacks?", []string{"Yes", "No"})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @draftcode, I would appreciate your input and guidance on the copy for this :)

@Brookke Brookke marked this pull request as ready for review July 25, 2024 14:28
Copy link
Contributor

aviator-app bot commented Jul 25, 2024

FlexReview Summary

Based on the code complexity and the author's expertise score, these are the suggested reviewers:

  • @draftcode (current review load: 1)

See the list of alternate reviewers in the detailed breakdown below.

Detailed Breakdown Author’s expertise score for the modified files:
  • cmd/av/stack_sync.go (0.00)
  • internal/git/git.go (0.00)
Files Reviewers
internal/git/git.go @draftcode (score: 1.00, current review load: 1),
@jainankit (score: 0.69, current review load: 5),
@alex-aviator (score: 0.14, current review load: 1)

† Indicates that the file doesn't need an expert review. (?)

See full breakdown of the reviewers on the Aviator webapp.

@aviator-app aviator-app bot requested a review from draftcode July 25, 2024 14:29
@Brookke Brookke changed the title draft: check if users in on trunk and prompt to sync all instead feat: check if users in on trunk and prompt to sync all instead Jul 25, 2024
@Brookke Brookke changed the title feat: check if users in on trunk and prompt to sync all instead feat: check if user is on trunk and prompt to sync all instead Jul 25, 2024
@aviator-app aviator-app bot merged commit bcc706f into aviator-co:master Jul 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants