Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent av commit amend and av commit create for merged branches … #318

Conversation

Brookke
Copy link
Contributor

@Brookke Brookke commented Jun 7, 2024

#312

Todo

  • add tests
  • sync branch state before checking

Copy link
Contributor

aviator-app bot commented Jun 7, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@Brookke
Copy link
Contributor Author

Brookke commented Jun 7, 2024

Unsure how best to test this given it uses the github api. I have at least made sure that the commands pass the tests by not blocking the command if UpdatePullRequestState fails, this also ensures the CLI can be used offline

@Brookke Brookke marked this pull request as ready for review June 7, 2024 21:16
Copy link
Contributor

aviator-app bot commented Jun 7, 2024

FlexReview Summary

There is not enough data in the repository for FlexReview to determine suggested reviewers.

Detailed Breakdown Author’s expertise score for the modified files:
  • cmd/av/commit_amend.go (0.00)
  • cmd/av/commit_create.go (0.00)

See full breakdown of the reviewers on the Aviator webapp.

@Brookke Brookke marked this pull request as draft June 7, 2024 21:28
cmd/av/commit_amend.go Outdated Show resolved Hide resolved
@Brookke Brookke force-pushed the fix/312/prevent-ammend-and-commit-on-merged-branches branch from 12c923b to 0b42bcb Compare June 7, 2024 22:24
@Brookke Brookke force-pushed the fix/312/prevent-ammend-and-commit-on-merged-branches branch from 0b42bcb to d85b6a0 Compare June 7, 2024 22:26
@Brookke Brookke marked this pull request as ready for review June 7, 2024 22:27
@Brookke Brookke marked this pull request as draft June 10, 2024 09:40
@Brookke Brookke marked this pull request as ready for review June 10, 2024 13:02
cmd/av/commit_amend.go Outdated Show resolved Hide resolved
@aviator-app aviator-app bot merged commit b51ed5a into aviator-co:master Jun 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants