-
-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sleet #3306
Add sleet #3306
Conversation
Thank you for contributing with awesome-go, we will revise your contribution as soon as possible. Automation body links content check:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review:
- coverage is 70.95%
[...] then coverage should be >= 80% for non-data-related packages and >=90% for data related packages [...]
read more: https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md#quality-standards
working on adding test. For golint, it seems guideline isn't super explicit about requirement. Is 100% golint requirement? I want to avoid having redundunt comment like below
|
FWIW author of lint suggests ignoring lint when it's not relevant golang/lint#186 (comment) |
We don't ask for 100% lint, we recommend that you have all lint items corrected to keep the quality of your package to a minimum.
|
IMO in some cases (please refer to my example above), "fixing" lint would actually do more harm than benefit. When variable name is self explanatory I prefer not to have comment. Anyways we're working on increasing coverage. I'll update here once it's ready |
@avelino coverage is now 80%+ https://codecov.io/gh/BoltApp/sleet Please kindly review again. |
Make sure that you've checked the boxes below before you submit PR: