-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add separate .clang-tidy-ci file #4918
Conversation
Signed-off-by: veqcc <[email protected]>
@veqcc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until this discussion is resolved.
https://github.com/orgs/autowarefoundation/discussions/4876#discussioncomment-9879362
Signed-off-by: veqcc <[email protected]>
Signed-off-by: veqcc <[email protected]>
Is the plan to add the same file in autoware.universe as well once this is merged? |
they are using this file here. No need to change in universe. |
Signed-off-by: veqcc <[email protected]>
Description
This is the first step to achive the proposal: https://github.com/orgs/autowarefoundation/discussions/4876 .
I have made the following changes:
clang-tidy-ci
for CI workflowAnalyzeTemporaryDtors: false
FormatStyle: none
Checks
andCheckOptions
are exactly the same as original.After this PR is merged, then each PR in autoware.universe would pass
clang-tidy-differential
workflow, unless it invokes new warnings.Tests performed
The clang-tidy warnings are obtained in tier4 universe v0.29.0: https://github.com/tier4/autoware.universe/tree/v0.29.0 .
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.