Skip to content

Commit

Permalink
Bump authoring duration for async backing to 2s. (paritytech#5195)
Browse files Browse the repository at this point in the history
Should be safe on all production network. 

I noticed that Paseo needs to be updated, it is lacking behind in a
couple of things.

Execution environment parameters should be updated to those of Polkadot:

```
[
      {
        MaxMemoryPages: 8,192
      }
      {
        PvfExecTimeout: [
          Backing
          2,500
        ]
      }
      {
        PvfExecTimeout: [
          Approval
          15,000
        ]
      }
    ]
  ]
  ```

---------

Co-authored-by: eskimor <[email protected]>
  • Loading branch information
eskimor and eskimor authored Aug 12, 2024
1 parent bc22f08 commit 819a581
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 3 deletions.
2 changes: 1 addition & 1 deletion cumulus/polkadot-parachain/src/service.rs
Original file line number Diff line number Diff line change
Expand Up @@ -832,7 +832,7 @@ where
relay_chain_slot_duration,
proposer: Proposer::new(proposer_factory),
collator_service,
authoring_duration: Duration::from_millis(1500),
authoring_duration: Duration::from_millis(2000),
reinitialize: false,
},
};
Expand Down
4 changes: 2 additions & 2 deletions docs/sdk/src/guides/async_backing_guide.rs
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@
//! - In the `para_client` field, pass in a cloned para client rather than the original
//! - Add a `para_backend` parameter after `para_client`, passing in our para backend
//! - Provide a `code_hash_provider` closure like that shown below
//! - Increase `authoring_duration` from 500 milliseconds to 1500
//! - Increase `authoring_duration` from 500 milliseconds to 2000
//! ```ignore
//! let params = AuraParams {
//! ..
Expand All @@ -185,7 +185,7 @@
//! client.code_at(block_hash).ok().map(|c| ValidationCode::from(c).hash())
//! },
//! ..
//! authoring_duration: Duration::from_millis(1500),
//! authoring_duration: Duration::from_millis(2000),
//! ..
//! };
//! ```
Expand Down
15 changes: 15 additions & 0 deletions prdoc/pr_5195.prdoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0
# See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json

title: Bump Aura authoring duration to 2s.

doc:
- audience: Node Dev
description: |
This PR bumps the Aura authoring duration in the asynchronous backing
guide and the polkadot-parachain service file to 2s in order to make
better use of the provided coretime.

crates:
- name: polkadot-parachain-bin
bump: patch

0 comments on commit 819a581

Please sign in to comment.