Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent project is already evaluated error #574

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Artemych
Copy link

Please take a look at the issue #435

For some mutlimodule projects usage of that plugin could not be possible as users receives an error like: "Cannot run Project.afterEvaluate(Action) when the project is already evaluated" during the project sync.

It could be caused by manipulating with the evaluation order. To prevent that we have to check the current internal project state.

@autonomousapps
Copy link
Owner

I can't merge this without a regression test. Could you provide detailed steps on how I'd set up a project so that this would be necessary?

@Artemych
Copy link
Author

I can't merge this without a regression test. Could you provide detailed steps on how I'd set up a project so that this would be necessary?

regression pipeline is passed.

About the steps:
In our project we have some logic with the evaluation order like here. Hope these description will be enough.

@Artemych Artemych force-pushed the fix/project-already-evaluated-error branch from 4f45dbd to b8d1dc5 Compare February 7, 2022 20:35
@autonomousapps
Copy link
Owner

I appreciate you keeping your branch up to date. Unfortunately, I haven't had time to write a test on behalf of this change. Is that something you'd be interested in doing? I'm willing to offer guidance.

@Artemych
Copy link
Author

Artemych commented Feb 8, 2022

I appreciate you keeping your branch up to date. Unfortunately, I haven't had time to write a test on behalf of this change. Is that something you'd be interested in doing? I'm willing to offer guidance.

Trying to do my best to add the test for that particular case. For now unfortunately I haven't time but hope i will do that by the end of the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants