Cleanup, remember to use 'final' visibility modifier.

autonomousapps · Aug 3, 2023 · cbd5cd0 · cbd5cd0
1 parent 837c1fb
commit cbd5cd0
Show file tree

Hide file tree

Showing 11 changed files with 10 additions and 11 deletions.
diff --git a/...unctionalTest/groovy/com/autonomousapps/android/projects/AllVariantsIgnoredProject.groovy b/...unctionalTest/groovy/com/autonomousapps/android/projects/AllVariantsIgnoredProject.groovy
@@ -8,7 +8,7 @@ import com.autonomousapps.model.ProjectAdvice
 import static com.autonomousapps.AdviceHelper.moduleCoordinates
 import static com.autonomousapps.AdviceHelper.projectAdviceForDependencies
 
-class AllVariantsIgnoredProject extends AbstractVariantProject {
+final class AllVariantsIgnoredProject extends AbstractVariantProject {
 
   AllVariantsIgnoredProject(String agpVersion) {
     super(agpVersion)

diff --git a/src/functionalTest/groovy/com/autonomousapps/android/projects/AllVariantsProject.groovy b/src/functionalTest/groovy/com/autonomousapps/android/projects/AllVariantsProject.groovy
@@ -6,7 +6,7 @@ import com.autonomousapps.model.ProjectAdvice
 import static com.autonomousapps.AdviceHelper.moduleCoordinates
 import static com.autonomousapps.AdviceHelper.projectAdviceForDependencies
 
-class AllVariantsProject extends AbstractVariantProject {
+final class AllVariantsProject extends AbstractVariantProject {
 
   AllVariantsProject(String agpVersion) {
     super(agpVersion)

diff --git a/...functionalTest/groovy/com/autonomousapps/android/projects/AndroidTestSourceProject.groovy b/...functionalTest/groovy/com/autonomousapps/android/projects/AndroidTestSourceProject.groovy
@@ -7,7 +7,7 @@ import com.autonomousapps.model.ProjectAdvice
 import static com.autonomousapps.AdviceHelper.*
 import static com.autonomousapps.kit.Dependency.*
 
-class AndroidTestSourceProject extends AbstractAndroidProject {
+final class AndroidTestSourceProject extends AbstractAndroidProject {
 
   final GradleProject gradleProject
   private final String agpVersion

diff --git a/...nctionalTest/groovy/com/autonomousapps/android/projects/DebugVariantIgnoredProject.groovy b/...nctionalTest/groovy/com/autonomousapps/android/projects/DebugVariantIgnoredProject.groovy
@@ -8,7 +8,7 @@ import com.autonomousapps.model.ProjectAdvice
 import static com.autonomousapps.AdviceHelper.moduleCoordinates
 import static com.autonomousapps.AdviceHelper.projectAdviceForDependencies
 
-class DebugVariantIgnoredProject extends AbstractVariantProject {
+final class DebugVariantIgnoredProject extends AbstractVariantProject {
 
   DebugVariantIgnoredProject(String agpVersion) {
     super(agpVersion)

diff --git a/...tionalTest/groovy/com/autonomousapps/android/projects/ReleaseVariantIgnoredProject.groovy b/...tionalTest/groovy/com/autonomousapps/android/projects/ReleaseVariantIgnoredProject.groovy
@@ -8,7 +8,7 @@ import com.autonomousapps.model.ProjectAdvice
 import static com.autonomousapps.AdviceHelper.moduleCoordinates
 import static com.autonomousapps.AdviceHelper.projectAdviceForDependencies
 
-class ReleaseVariantIgnoredProject extends AbstractVariantProject {
+final class ReleaseVariantIgnoredProject extends AbstractVariantProject {
 
   ReleaseVariantIgnoredProject(String agpVersion) {
     super(agpVersion)

diff --git a/src/functionalTest/groovy/com/autonomousapps/android/projects/ResProject.groovy b/src/functionalTest/groovy/com/autonomousapps/android/projects/ResProject.groovy
@@ -14,7 +14,7 @@ import static com.autonomousapps.kit.Dependency.project
  *
  * The only reference to the lib2 project is through an ID that lib2 provides.
  */
-class ResProject extends AbstractAndroidProject {
+final class ResProject extends AbstractAndroidProject {
 
   final GradleProject gradleProject
   private final String agpVersion

diff --git a/src/functionalTest/groovy/com/autonomousapps/android/projects/TestSourceProject.groovy b/src/functionalTest/groovy/com/autonomousapps/android/projects/TestSourceProject.groovy
@@ -7,7 +7,7 @@ import com.autonomousapps.model.ProjectAdvice
 import static com.autonomousapps.AdviceHelper.*
 import static com.autonomousapps.kit.Dependency.*
 
-class TestSourceProject extends AbstractAndroidProject {
+final class TestSourceProject extends AbstractAndroidProject {
 
   final GradleProject gradleProject
   private final String agpVersion

diff --git a/src/functionalTest/groovy/com/autonomousapps/jvm/projects/AbiGenericsProject.groovy b/src/functionalTest/groovy/com/autonomousapps/jvm/projects/AbiGenericsProject.groovy
@@ -12,7 +12,7 @@ import static com.autonomousapps.AdviceHelper.*
 import static com.autonomousapps.kit.Dependency.kotlinStdLib
 import static com.autonomousapps.kit.Dependency.project
 
-class AbiGenericsProject extends AbstractProject {
+final class AbiGenericsProject extends AbstractProject {
 
   enum SourceKind {
     CLASS, METHOD, FIELD

diff --git a/src/functionalTest/groovy/com/autonomousapps/jvm/projects/AbiInterfaceProject.groovy b/src/functionalTest/groovy/com/autonomousapps/jvm/projects/AbiInterfaceProject.groovy
@@ -11,7 +11,7 @@ import com.autonomousapps.model.ProjectAdvice
 import static com.autonomousapps.AdviceHelper.*
 import static com.autonomousapps.kit.Dependency.project
 
-class AbiInterfaceProject extends AbstractProject {
+final class AbiInterfaceProject extends AbstractProject {
 
   final GradleProject gradleProject
   private final abstractProject = project('implementation', ':abstract')

diff --git a/src/functionalTest/groovy/com/autonomousapps/jvm/projects/FindDeclarationsProject.groovy b/src/functionalTest/groovy/com/autonomousapps/jvm/projects/FindDeclarationsProject.groovy
@@ -9,7 +9,7 @@ import java.nio.file.Files
 import static com.autonomousapps.kit.Dependency.okHttp
 import static com.autonomousapps.kit.Dependency.okio
 
-class FindDeclarationsProject extends AbstractProject {
+final class FindDeclarationsProject extends AbstractProject {
 
   final name = 'proj'
   final GradleProject gradleProject

diff --git a/src/main/kotlin/com/autonomousapps/subplugin/ProjectPlugin.kt b/src/main/kotlin/com/autonomousapps/subplugin/ProjectPlugin.kt
@@ -954,4 +954,3 @@ private fun Project.shouldAnalyzeSourceSetForProject(sourceSetName: String, proj
   return project.getExtension().issueHandler.shouldAnalyzeSourceSet(sourceSetName, projectPath)
     && (project.shouldAnalyzeTests() || sourceSetName != SourceSet.TEST_SOURCE_SET_NAME)
 }
-
Original file line number	Diff line number	Diff line change
Expand Up		@@ -954,4 +954,3 @@ private fun Project.shouldAnalyzeSourceSetForProject(sourceSetName: String, proj
		return project.getExtension().issueHandler.shouldAnalyzeSourceSet(sourceSetName, projectPath)
		&& (project.shouldAnalyzeTests() \|\| sourceSetName != SourceSet.TEST_SOURCE_SET_NAME)
		}