Account for hooks in viewFeedback instead of feedback output

[michellexliu]

Summary

Summary generated by Reviewpad on 01 Dec 23 19:19 UTC

This pull request includes some changes to the assessments_controller.rb file.

• Added a new line to retrieve autograded_scores.
• Renamed the "@finishedAutograding" variable to "finishedAutograding".
• Updated the condition for redirecting to "viewFeedback" if no score is available.
• Modified the "parseScore" method to use the "scoreHashFromScores" method.
• Created a new method "scoreHashFromScores" to convert scores to a hash.
• Other minor code cleanup and refactoring.

Description

Pull viewFeedback sidebar grades from @submission.scores rather than autograder output so that hooks are accounted for.

Autograded problem:

Non-autograded problem:

Motivation and Context

Resolves #1914 - Ensures viewFeedback scores correctly account for any hooks (i.e., parseAutoresult)

How Has This Been Tested?

Create new autograded assignment: solvescryptarithm.zip

Edit assessment, create a new non-autograded problem

Create a new submission

Click into "Grade submissions," and add a non-autograded feedback, with "released" checked

Verify the following:

• Autograded feedback shows correctly (shows all autograded-scores tallied up on the sidebar, with the correct autograded total)
• Non-autograded feedback shows correctly (shows specific problem score & grader email)

Also check that assignments where autograder throws an error work correctly & formatted feedback is displayed properly

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have run rubocop and erblint for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
• My change requires a change to the documentation, which is located at Autolab Docs
• I have updated the documentation accordingly, included in this PR

Other issues / help required

If unsure, feel free to submit first and we'll help you along.

[coderabbitai]

Walkthrough

Walkthrough

The changes primarily focus on enhancing the user interface and improving the validation and error handling in the application. The updates include modifications to the assessment forms, adding new validation methods for assessment files, and improving error handling in controllers. The changes also introduce new features like unlimited submissions, grace days, and default values for penalties.

Changes

File(s)	Summary
app/assets/javascripts/edit_assessment.js, app/assets/stylesheets/style.css.scss, app/views/assessments/_edit_basic.html.erb, app/views/assessments/_edit_penalties.html.erb	Introduced changes to the assessment form, including event listeners for checkboxes, CSS modifications, and new HTML elements for error messages.
app/controllers/api/v1/assessments_controller.rb, app/controllers/assessment/handout.rb, app/models/assessment.rb	Added validation checks for assessment files (handout, writeup) to ensure they are within the assessment folder.
app/controllers/assessments_controller.rb, app/controllers/courses_controller.rb, app/controllers/scoreboards_controller.rb	Improved error handling in controllers, added new variables and methods, and updated existing methods.
app/form_builders/form_builder_with_date_time_input.rb, app/models/score_adjustment.rb	Updated class methods to include additional options and modified string representation of objects.
app/views/assessments/_submission_history_row.html.erb, app/views/assessments/_submission_history_table.html.erb	Updated HTML templates to display submission details related to late submissions and grace days.
app/views/assessments/edit.html.erb, app/views/courses/_courseFields.html.erb	Updated form views, including changes to placeholders, help text, and error message rendering.
app/views/scoreboards/_error_icon.html.erb, app/views/scoreboards/_form.html.erb, app/views/scoreboards/show.html.erb	Added and updated views related to scoreboards, including error message display and conditional rendering of table cells.
config/initializers/core_ext.rb	Introduced new methods to convert strings and nil values to boolean.

Assessment against linked issues

Objective	Addressed	Explanation
viewFeedback page shows final scores after hooks	❌	The changes in the code do not directly address the behavior of the viewFeedback page as described in the linked issue.

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• If you reply to a review comment from CodeRabbit, the bot will automatically respond.
• To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
• Note: Review comments are made on code diffs or files, not on the PR overview.
• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[najclark]

lgtm, testing worked as expected. The comments by @coderrabbitai seem like reasonable nits.

[michellexliu]

@coderabbitai review