Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for using a custom scheme in the callback URL [SDK-2223] #351

Merged
merged 3 commits into from
Dec 29, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Dec 28, 2020

Changes

The Bundle Identifier / Application ID might contain characters not allowed in a URL scheme. This PR adds support for specifying a custom scheme to be used instead.

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket added this to the v2-Next milestone Dec 28, 2020
@Widcket Widcket requested a review from lbalmaceda December 28, 2020 03:41
@Widcket Widcket requested a review from a team as a code owner December 28, 2020 03:41
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some docs on the method and/or in the README to explain how this can be used and in what scenarios it could be useful.

src/webauth/index.js Show resolved Hide resolved
@Widcket Widcket requested a review from lbalmaceda December 28, 2020 17:48
@Widcket
Copy link
Contributor Author

Widcket commented Dec 29, 2020

Please add some docs on the method and/or in the README to explain how this can be used and in what scenarios it could be useful.

@lbalmaceda done.

@lbalmaceda
Copy link
Contributor

@Widcket Thanks for documenting the parameter. But is not just passing the new option, one would also need to update the intent-filter in the AndroidManifest.xml file, right?
Developers could benefit from reading that guidance somewhere, e.g. in the readme. I was thinking of adding a small section like we do here for iOS' SSO. WDYT?

@Widcket Widcket merged commit 8b28dba into master Dec 29, 2020
@Widcket Widcket deleted the feature/custom-scheme branch December 29, 2020 18:29
@Widcket Widcket mentioned this pull request Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants