Add compileOptions for JDK 8 #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The android module on this SDK makes use of the Android Gradle plugin version 3.5.2, which according to this table means that the Gradle version required is 5.4.1+. I've installed JDK 7, cloned our react-native sample app, and downgraded its gradle wrapper version to 5.4.1. Then when I tried running the app on an Android emulator, I ran into this issue:
Which means, this SDK is already requiring JDK 8+ locally in order to be used on other apps. That explained I'm OK with accepting this change since it's not a breaking change to existing users. |
lbalmaceda
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes gradle builds with a minSdkVersion lower than 24
Changes
Added
compileOptionsentry toandroid/build.gradle.References
#322
Testing
See reproduction guide in #322
Checklist