Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update packages and utilize error classes from rest-facade correctly (Fixes #154) #183

Merged
merged 3 commits into from
Jun 16, 2017
Merged

Update packages and utilize error classes from rest-facade correctly (Fixes #154) #183

merged 3 commits into from
Jun 16, 2017

Conversation

charsleysa
Copy link
Contributor

Fixes #154

  • Use error classes from rest-facade for consistency
  • Fix APIError not being constructed correctly by rest-facade due to missing errorFormatter config
  • Fix test case in oauth.tests.js incorrectly using return twice

charsleysa added 2 commits June 2, 2017 12:03
@charsleysa
- Use error classes from rest-facade for consistency
f20cf2b 
- Fix APIError not being constructed correctly by rest-facade due to missing errorFormatter config
- Fix test case in oauth.tests.js incorrectly using return twice
@charsleysa
- Revert bluebird version to be inline with rest-facade
c7b531c
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 95.567% when pulling c7b531c on charsleysa:master into ba4b4f9 on auth0:master.

@charsleysa charsleysa mentioned this pull request Jun 2, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 95.524% when pulling e5e9405 on charsleysa:master into cdcf916 on auth0:master.

@hzalaz hzalaz merged commit f2ed9a6 into auth0:master Jun 16, 2017
@hzalaz hzalaz modified the milestone: v2.7.0 Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzalaz hzalaz hzalaz approved these changes

Assignees
No one assigned
Labels
CH: Changed
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@charsleysa @coveralls @hzalaz