Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix default condition should be the last one #199

Merged
merged 1 commit into from
Aug 22, 2023
Merged

fix default condition should be the last one #199

merged 1 commit into from
Aug 22, 2023

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Aug 22, 2023 •
edited
Loading

Description

Default should be the last key in the exports, mainly for webpack.

References

auth0/node-auth0#912

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@frederikprijck frederikprijck requested a review from a team as a code owner August 22, 2023 08:33
@frederikprijck frederikprijck enabled auto-merge (squash) August 22, 2023 08:35
jonkoops
jonkoops approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I wanted to create a PR for this but you beat me to it 😄

@jonkoops
Copy link
Contributor

Also, a very cool tool to check this is publint, which indeed marks this as an issue.

@frederikprijck frederikprijck merged commit fad5d53 into beta Aug 22, 2023
@frederikprijck frederikprijck deleted the frederikprijck-patch-1 branch August 22, 2023 09:02
@frederikprijck
Copy link
Member Author

Thanks @jonkoops , I opened a PR to add publint (and eslint while I was at it). Also introduced publint in our beta for https://github.com/auth0/node-auth0

@jonkoops
Copy link
Contributor

Nice! I'll take a look at that as well 😄

@frederikprijck frederikprijck mentioned this pull request Sep 5, 2023
Merged
frederikprijck added a commit that referenced this pull request Oct 27, 2023
@frederikprijck
fix default condition should be the last one (#199)
57c5d42
@rpt-uk-github rpt-uk-github mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

@jonkoops jonkoops jonkoops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frederikprijck @jonkoops @adamjmcgrath