Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using any bundlers but use tsc instead #192

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Avoid using any bundlers but use tsc instead #192

merged 5 commits into from
Aug 16, 2023

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Aug 14, 2023 •
edited
Loading

Description

Given the size of the library, we might want to consider dropping any bundler altogether but move everything into a single file.

According to Are The Types Wrong, this is still outputting correct types:
image

Marked as draft to further investigate.

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@frederikprijck frederikprijck mentioned this pull request Aug 14, 2023
Closed
@frederikprijck frederikprijck changed the title Avoid using any bundlers but use tsc Avoid using any bundlers but use tsc and drop UMD Aug 14, 2023
@frederikprijck
Copy link
Member Author

frederikprijck commented Aug 14, 2023 •
edited
Loading

Needs to be rebased after #193 is merged as I wanted to drop UMD separately to keep this PR more focussed.

@jonkoops jonkoops mentioned this pull request Aug 14, 2023
Closed
@jonkoops
Copy link
Contributor

I'll put in a review for this once we merge #193 😄

@frederikprijck frederikprijck marked this pull request as ready for review August 15, 2023 18:34
@frederikprijck frederikprijck requested a review from a team as a code owner August 15, 2023 18:34
@frederikprijck
Copy link
Member Author

Rebased on top of latest beta.

@jonkoops
Copy link
Contributor

Got some review comments, but I think it would be better as a PR, so I will open one up on top of this one.

@jonkoops jonkoops mentioned this pull request Aug 16, 2023
Merged
@jonkoops
Copy link
Contributor

I've created #194 with some work that came out of the review. Everything else is looking good to me 👍

@frederikprijck
Copy link
Member Author

Thanks @jonkoops !

@frederikprijck frederikprijck enabled auto-merge (squash) August 16, 2023 11:09
@frederikprijck frederikprijck changed the title Avoid using any bundlers but use tsc and drop UMD Avoid using any bundlers but use tsc instead Aug 16, 2023
@frederikprijck frederikprijck enabled auto-merge (squash) August 16, 2023 11:10
@frederikprijck frederikprijck merged commit b0d9fb7 into beta Aug 16, 2023
@frederikprijck frederikprijck deleted the chore/drop-bundlers branch August 16, 2023 11:11
@frederikprijck frederikprijck mentioned this pull request Aug 16, 2023
Merged
frederikprijck added a commit that referenced this pull request Oct 27, 2023
@frederikprijck @jonkoops
Avoid using any bundlers but use tsc instead (#192)
1113ee4 
Co-authored-by: Jon Koops <[email protected]>
@rpt-uk-github rpt-uk-github mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frederikprijck @jonkoops @ewanharris