-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(systemjs-bundling): include dependency name in bundle config #679
Merged
JeroenVinke
merged 1 commit into
aurelia:master
from
simonfox:feature/#676-bundle-config
Jul 18, 2017
Merged
fix(systemjs-bundling): include dependency name in bundle config #679
JeroenVinke
merged 1 commit into
aurelia:master
from
simonfox:feature/#676-bundle-config
Jul 18, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Bundle.getBundledModuleIds` was only returning the ids of the traced files in the case of a package dependency. This change modifies `DependencyInclusion` to include the actual package name in the module ids for the dependency. closes aurelia#676
Thanks @simonfox! I tried this out and it does fix the error mentioned in #676 but I'm getting another one with this fix. This fix is still good though.
When I only have jquery in a bundle called "materialize-bundle" and do
then it does not give any errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundle.getBundledModuleIds
was only returning the ids of the traced files in the case of a package dependency. This change modifiesDependencyInclusion
to include the actual package name in the module ids for the dependency.closes #676