-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
find location of packages outside of node_modules, support packages without package.json #576
find location of packages outside of node_modules, support packages without package.json #576
Conversation
I like that idea. I won't have time to really look into it until Monday though (gone over the weekend). So in your example, it would search up |
It wouldn't traverse the directory tree to find the package root like it does with |
Gotcha, I'm tracking now. Sounds reasonable to me! |
41f0cbe
to
3e46766
Compare
3e46766
to
c225bb7
Compare
@EisenbergEffect I believe this is good to go. I decided to add another fix to this PR, because they depend on each other. So this fixes:
When you merge this, could you also merge aurelia/framework#762? |
@EisenbergEffect, sorry to bump. Could we get this in? |
fixes #567
@AStoker i'd like to hear your thoughts on the following. We need the root folder of a package (kept in
description.location
and looks something likec:/development/my-app/node_modules/my-plugin/
) for two things:app-bundle.js
when they should have ended up invendor-bundle.js
(or other)Currently the root folder of packages inside the node_modules folder is determined as follows. You resolve the
path
of the package (as defined in aurelia.json) which could bec:/development/my-app/node_modules/my-plugin/dist/
and traverse up the folder tree until you hit thenode_modules
. The path until the first segment afternode_modules
is then used as the package root folder (c:/development/my-app/node_modules/my-plugin
).When you keep packages outside the node_modules folder, this trick does not work because there is no standard folder name like
node_modules
to look for in the path. So as far as I know there is no reliable way of knowing what the root folder of the package is when the package is not inside thenode_modules
folder.So this PR enforces that if you define dependencies outside the
node_modules
folder, that you must define apackageRoot
: