Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cypress task): Return error when tests fail #1058

Merged

Conversation

michaelw85
Copy link
Contributor

Make au cypress --run emit error when a test failed to allow a build process/step to fail.

Closes #1057

Make au cypress --run emit error when a test failed to allow a build
process/step to fail.

Closes aurelia#1057
@michaelw85
Copy link
Contributor Author

@huochunpeng This PR is similar to #1053

Copy link
Member

@3cp 3cp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we’d better follow gulp example to use the name cb instead of resolve.

Change resolve to cb to follow gulp standards.
@michaelw85
Copy link
Contributor Author

Updated resolve to cb.

Here's the result of a failed run btw:
image

@3cp
Copy link
Member

3cp commented Feb 20, 2019

@EisenbergEffect this can be merged.

@EisenbergEffect EisenbergEffect merged commit ced9d40 into aurelia:master Feb 21, 2019
@michaelw85 michaelw85 deleted the emit_error_when_cypress_fails branch February 21, 2019 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants