Merge pull request #1080 from huochunpeng/ie-promise

fix(skeleton): fix Promise polyfill on IE
aurelia · Apr 18, 2019 · 5d39d85 · 5d39d85
2 parents 9c139e1 + bc377dc
commit 5d39d85
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 6 deletions.
diff --git a/lib/dependencies.json b/lib/dependencies.json
@@ -29,7 +29,6 @@
   "clean-webpack-plugin": "^1.0.1",
   "connect-history-api-fallback": "^1.6.0",
   "copy-webpack-plugin": "^5.0.0",
-  "core-js": "^3.0.0",
   "cross-env": "^5.2.0",
   "cssnano": "^4.1.10",
   "css-loader": "^1.0.0",
@@ -83,6 +82,7 @@
   "opn": "^5.4.0",
   "postcss-loader": "^3.0.0",
   "postcss-url": "^8.0.0",
+  "promise-polyfill": "^8.1.0",
   "protractor": "^5.4.2",
   "regenerator-runtime": "0.13.2",
   "requirejs": "^2.3.6",

diff --git a/package-lock.json b/package-lock.json
diff --git a/skeleton/cli-bundler/aurelia_project/aurelia.json b/skeleton/cli-bundler/aurelia_project/aurelia.json
@@ -144,6 +144,7 @@
       {
         "name": "vendor-bundle.js",
         "prepend": [
+          "node_modules/promise-polyfill/dist/polyfill.min.js",
           // @if feat.requirejs
           "node_modules/requirejs/require.js"
           // @endif

diff --git a/skeleton/common/package.json b/skeleton/common/package.json
@@ -21,11 +21,11 @@
     "aurelia-cli": "",
     "aurelia-testing": "",
     "aurelia-tools": "",
-    "core-js": "",
     "gulp": "",
     "minimatch": "",
     "through2": "",
     "vinyl-fs": "",
+    "promise-polyfill": "",
 
     // @if feat.babel
     "regenerator-runtime": "",

diff --git a/skeleton/plugin/dev-app/main.ext b/skeleton/plugin/dev-app/main.ext
@@ -1,5 +1,6 @@
-import 'core-js/stable';
 // @if feat.babel
+// regenerator-runtime is to support async/await syntax in ESNext.
+// If you don't use async/await, you can remove regenerator-runtime.
 import 'regenerator-runtime/runtime';
 // @endif
 // @if feat.typescript

diff --git a/skeleton/scaffold-minimum/src/main.ext b/skeleton/scaffold-minimum/src/main.ext
@@ -1,5 +1,6 @@
-import 'core-js/stable';
 // @if feat.babel
+// regenerator-runtime is to support async/await syntax in ESNext.
+// If you don't use async/await, you can remove regenerator-runtime.
 import 'regenerator-runtime/runtime';
 // @endif
 // @if feat.typescript

diff --git a/skeleton/scaffold-navigation/src/main.ext b/skeleton/scaffold-navigation/src/main.ext
@@ -1,5 +1,6 @@
-import 'core-js/stable';
 // @if feat.babel
+// regenerator-runtime is to support async/await syntax in ESNext.
+// If you don't use async/await, you can remove regenerator-runtime.
 import 'regenerator-runtime/runtime';
 // @endif
 import 'bootstrap';

diff --git a/skeleton/webpack/webpack.config.js b/skeleton/webpack/webpack.config.js
@@ -287,6 +287,7 @@ module.exports = ({ production, server, extractCss, coverage, analyze, karma } =
       $: 'jquery',
       jQuery: 'jquery',
     // @endif
+      'Promise': ['promise-polyfill', 'default']
     }),
     new ModuleDependenciesPlugin({
       'aurelia-testing': ['./compile-spy', './view-spy']