Added "one" method to all classes inheriting from Backbone.Event. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| one: (ev, callback, context) -> | ||
| self = this | ||
|
|
||
| fn = -> |
There was a problem hiding this comment.
For some reason all the cool kids use .apply, but in this case I think it's the same as this which is much easier to read:
this.unbind ev, fn
There was a problem hiding this comment.
The issue is that, when fn is executed, its context may have changed. For instance, in jQuery, the callback is executed within the calling element's context. Thus, by using apply here, we make sure that we call unbind and bind with the correct context..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.