Add package setting to toggle full-width status-bar #152

Alhadis · 2016-06-07T07:19:09Z

I have writer's block, so I'll just echo @simurai's words, because he put it best:

But somehow it feels wrong. I think the reason is because the status-bar changes based on the active editor and should somewhat stay connected to it. Full-width at the bottom it feels like it's something more global and less related to the active editor.

I agree wholeheartedly, and some other users might too. Artistic rationale aside, stubborn and change-resilient users like me would appreciate having a setting to restore the status-bar's old appearance:

If it needs to be said, the setting's default value is to use the full-width status bar:

This is how the option appears in the package's settings:

simurai · 2016-06-07T07:50:00Z

Here another thought: Separate the status-bar items based on if something is permanent (global) or just temporary (per file):

Then the permanent items, like updates etc. could be on the left and under the "global" tree-view. On the right are all the items that change "per file". So the file name would be under the editor and look less disconnected..

..of course this falls flat for people that moved the tree-view to the right. And it might also be something that not all people like and demand the old the position back. 💭

Alhadis · 2016-06-07T08:00:39Z

... what we have now works perfectly fine. There's no point changing what we're already used to.

I believe many users made that point abundantly clear when v1.7.0 was released.

pradyunsg · 2016-06-07T08:01:24Z

I do think what has been proposed in this PR is the best compromise in the short-term.

@simurai has a nice idea. It might be a little too late to change the entire arrangement of the status-bar though.

But if someone comes up with a clean proposal for how this comes together (including not breaking the existing status-bar API), I'm all for it. It would be nice to have ~~some~~ such organization in the status bar.

of course this falls flat for people that moved the tree-view to the right.

No it doesn't. Just determine which side the tree-view is on (I'm assuming it's not too hard, from what I know of Atom's API) and switch sides.

Alhadis · 2016-06-07T08:04:14Z

Drag-and-drop might be nice.

pradyunsg · 2016-06-07T08:06:15Z

@simurai I think your idea is worth exploring but is still fairly disconnected to what is there in this PR.

Maybe open a new issue for discussing the separation of permanent and temporary status-bar items?

Alhadis · 2016-06-07T08:06:58Z

On it.

~~I'll bring it up in discuss.atom.io though, because the Atom team are swamped with enough issues as it is.~~

Done!

gluons · 2016-06-07T15:38:59Z

Wow! I really need this setting. Good news. 😄

gh0stonio · 2016-06-15T12:49:13Z

👍

pierreneter · 2016-07-03T19:08:18Z

i cant see that option in my status-bar setting @.@

Alhadis · 2016-07-04T08:05:36Z

i cant see that option in my status-bar setting @.@

That's because this pull-request hasn't been merged yet...

winstliu · 2016-07-15T12:12:35Z

/cc @atom/feedback

simurai · 2016-07-16T09:34:37Z

I'm not so sure. It's nice to have the option, but it also adds extra complexity.

For example the One theme has a bottom border for the tree-view that should be removed if the status-bar isn't full-width. Maybe an extra class has-full-width-status-bar on the body could help, but it's another case that needs to be tested when making changes.

Is this a good candidate for the init.coffee?

@statusBar = document.querySelector('.status-bar')
atom.workspace.addBottomPanel(item: @statusBar, priority: 0)

And depending on the theme, might need a styles.less tweak.

Alhadis · 2016-07-16T10:10:36Z

For example the One theme has a bottom border for the tree-view that should be removed if the status-bar isn't full-width

What's wrong with moving the border to the status bar?

I'm also not sure where or how it adds complexity...

Alhadis · 2016-07-16T12:09:49Z

BTW, the tree-view has a package setting to control its position in the workspace as well:

Since it's (physically) connected to the status bar, it feels logical that the status bar would have a similar layout-influencing setting as well.

Personally, I really think init.coffee shouldn't be a dumping ground for every setting not expected to see common use. If we follow that train of thought, it'd going to lead to some very bloated startup scripts...

Packages define a nice, neat space for holding package-specific settings, so why not make the most of it? =)

armic · 2016-07-17T00:04:35Z

👍 As someone who toggles the atom-linter notifications quite often, the new position is fairly annoying.

lorenzos · 2016-07-18T10:11:17Z

👍 +1 Lint issues notifications are invisible for me, now that they are below the tree view!

simurai · 2016-07-24T02:45:16Z

I'm not entirely against this option, because options are nice to have. Just that in general, adding config options can increase complexity because you have to account for different situations and can't assume certain things anymore. And it might add an extra burden to package/theme authors to test against all the different options.

For example it's nice that the tree-view can be moved to the right, but then the notifications cover the tree-view atom/notifications#93 which isn't ideal for some.

I really think init.coffee shouldn't be a dumping ground for every setting not expected to see common use.

Yeah, it's hard to guess what is considered "common use". So I wanted to make sure that:

There aren't any side effects that we haven't thought about.
This option would have enough user adoption to warrant the cost of maintaining an extra setting.

Alhadis · 2016-07-24T09:34:16Z

There aren't any side effects that we haven't thought about.

Honestly, I can't see this introducing any issues. Even in uncommon scenarios:

An author needs to apply specific styling to the status bar when contained in a certain pane:
Simple CSS fix: .panel-bottom status-bar, .panel-footer status-bar.
Package authors need to query or detect changes to status bar position:
Atom's config API already covers that:

atom.config.get("status-bar.fullWidth");
atom.config.observe("status-bar.fullWidth");

I've also added specs to guard against regressions, just in case.

This option would have enough user adoption to warrant the cost of maintaining an extra setting.

At least seven other users who've seen this pull request have given a 👍, and a few others have even voiced their approval.

Alhadis · 2016-09-18T07:25:54Z

So... what's happening with this...?

blcarson · 2016-10-01T12:33:12Z

FWIW this change is driving me seriously batty. Is there an easy way I can get these changes in now?

Alhadis · 2016-10-01T12:47:01Z

Yep! cd to wherever you'd like to keep a forked project, and run this:

git clone https://github.com/Alhadis/status-bar.git
cd status-bar && git checkout width-setting
apm install && apm link -d .

CAVAET: This requires a project to be opened in development mode in order to take effect.

Which is what I've been doing every day for over two months now, and I'm getting kinda sick of it.

blcarson · 2016-10-01T13:09:59Z

Ahh - you're a saint!

I installed it in my ~/.atom/packages folder and it seems to work without developer mode. Any reason why you have to run through that process daily?

Alhadis · 2016-10-01T13:20:40Z

Erh, really? I wasn't aware Atom enabled you to "override" packages that way... to date, I've simply been repeating the steps described here. I'm not sure this is expected behaviour.

@simurai, any idea if this is a bug?

blcarson · 2016-10-01T13:26:16Z

Steps I took, in case it's helpful:

Cloned the repo to my ~/.atom/packages folder
Ran the commands you suggested
Opened atom in dev mode
Enabled your package (which seemed to turn on the default one as well)
Toggled the width option setting to off
Started atom in normal mode and settings persisted

I'm on Mac 10.12 if it makes any difference.

simurai · 2016-10-06T02:14:43Z

@Alhadis If you use apm link instead of apm link -d, then the package is available also in normal mode. The reason to use apm link -d while you work on a package is so that you can run both versions at the same time. A normal mode window with the published package and a dev mode window with your local package. Maybe not needed for all package, but if you mess something up locally, your normal mode window will still work as usual.

btw. the One themes got changed so that the borders wouldn't be an issue anymore.

Alhadis · 2016-10-06T02:30:02Z

Well, I know that... but seeing a core package listed as both a "Community Package" and a "Core "Package" looked pretty erroneous to me. But I digress.

My main question is: what's this bar's status?

simurai · 2016-10-06T04:37:03Z

My main question is: what's this bar's status?

Ya, it's a bit weird that it shows the atom avatar and the download counts for your linked package that isn't really published.

Alhadis · 2016-10-06T04:41:02Z

Eyyyyupp, that'll teach me for trying to be punny with a vague wisecrack (status-bar = "bar's status"). It sounded funnier in my head, honest.

It was a fatigue-encrypted way of asking if this PR is close to being merged yet...

simurai · 2016-10-06T08:02:53Z

Ahh.. hehe.. 😂

Well, I'm fine with either. But we need at least somebody else to review the code.

Alhadis · 2016-10-06T08:11:02Z

I'll send a Mars Bar to any Atom member who gets this and another light-and-easy PR reviewed this week. For real.

I say that on the grounds nobody is insane enough to send their address so a sleep-deprived Australian can order them a chocolate bar.

blcarson · 2016-10-06T10:51:11Z

I'll up the ante and will donate a case of your favorite candy bar (assuming its available on Amazon Prime) to the cause 🍫

Alhadis · 2016-10-06T10:57:45Z

⬆️ This guy. Right across it. 👍 👌

blcarson · 2016-10-12T09:04:38Z

New version of status bar breaks the width setting.

Alhadis · 2016-10-12T10:38:58Z

Not anymore.

blcarson · 2016-10-12T10:40:17Z

You're a rock star - thank you!

Alhadis · 2016-10-12T10:43:29Z

@nathansobo and I both fixed the same typo, which is all that triggered the conflict.

Amazing.

nathansobo · 2016-10-12T12:28:02Z

Thanks @Alhadis. This looks great and it will be nice to have this option.

Alhadis · 2016-10-12T12:35:28Z

If I weren't in the midst of crippling depression, I'd crown this the happiest day of my life. 👍 Thanks, Nathan.

bronson · 2016-11-10T19:39:16Z

Anyone know why I can't see this setting? Atom 1.12.0, status-bar 1.4.1. Would really like to use it!

(felt like including a screenshot for some reason...)

Ben3eeE · 2016-11-10T19:50:29Z

Atom 1.12.0, status-bar 1.4.1.

It is available in Atom 1.13.

bronson · 2016-11-10T20:24:43Z

Ah, that's an easy explanation. Thanks!

pierreneter · 2016-11-11T03:40:37Z

thanks! that's good news.

blcarson · 2016-11-11T03:41:48Z

It's in the latest beta now - working well so far.

Alhadis added 2 commits June 7, 2016 16:48

Add package setting to toggle full-width status-bar

b302c08

Add specs for full-width setting

061b4e8

gluons mentioned this pull request Jun 7, 2016

Move to the footer #133

Merged

winstliu added the needs-review label Jun 7, 2016

Merge branch 'master' into width-setting

194ba5d

Merge branch 'master' into width-setting

0e6470a

nathansobo merged commit 9f425dc into atom:master Oct 12, 2016

Alhadis deleted the width-setting branch October 12, 2016 12:35

Add package setting to toggle full-width status-bar #152

Add package setting to toggle full-width status-bar #152

Conversation

Alhadis commented Jun 7, 2016 • edited Loading

simurai commented Jun 7, 2016

Alhadis commented Jun 7, 2016

pradyunsg commented Jun 7, 2016 • edited Loading

Alhadis commented Jun 7, 2016

pradyunsg commented Jun 7, 2016 • edited Loading

Alhadis commented Jun 7, 2016 • edited Loading

gluons commented Jun 7, 2016

gh0stonio commented Jun 15, 2016

pierreneter commented Jul 3, 2016 • edited Loading

Alhadis commented Jul 4, 2016

winstliu commented Jul 15, 2016

simurai commented Jul 16, 2016

Alhadis commented Jul 16, 2016 • edited Loading

Alhadis commented Jul 16, 2016 • edited Loading

armic commented Jul 17, 2016

lorenzos commented Jul 18, 2016 • edited Loading

simurai commented Jul 24, 2016

Alhadis commented Jul 24, 2016 • edited Loading

Alhadis commented Sep 18, 2016

blcarson commented Oct 1, 2016

Alhadis commented Oct 1, 2016

blcarson commented Oct 1, 2016

Alhadis commented Oct 1, 2016

blcarson commented Oct 1, 2016

simurai commented Oct 6, 2016

Alhadis commented Oct 6, 2016

simurai commented Oct 6, 2016

Alhadis commented Oct 6, 2016

simurai commented Oct 6, 2016

Alhadis commented Oct 6, 2016

blcarson commented Oct 6, 2016

Alhadis commented Oct 6, 2016

blcarson commented Oct 12, 2016

Alhadis commented Oct 12, 2016

blcarson commented Oct 12, 2016

Alhadis commented Oct 12, 2016

nathansobo commented Oct 12, 2016

Alhadis commented Oct 12, 2016

bronson commented Nov 10, 2016 • edited Loading

Ben3eeE commented Nov 10, 2016

bronson commented Nov 10, 2016

pierreneter commented Nov 11, 2016

blcarson commented Nov 11, 2016

Alhadis commented Jun 7, 2016 •

edited

Loading

pradyunsg commented Jun 7, 2016 •

edited

Loading

pradyunsg commented Jun 7, 2016 •

edited

Loading

Alhadis commented Jun 7, 2016 •

edited

Loading

pierreneter commented Jul 3, 2016 •

edited

Loading

Alhadis commented Jul 16, 2016 •

edited

Loading

Alhadis commented Jul 16, 2016 •

edited

Loading

lorenzos commented Jul 18, 2016 •

edited

Loading

Alhadis commented Jul 24, 2016 •

edited

Loading

bronson commented Nov 10, 2016 •

edited

Loading