Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt at the fix previously tried with #1384.
I was able to see the auto-scrolling issues mentioned in the above PR by auto-scrolling with the various lists in the storybook, looks like it also needs a check for
window.document
, which this PR adds.Repro steps for original bug:
fixed list with fixed sidebar
Bug:
Invariant failed: Window scrolling is currently not supported for fixed lists. Aborting drag
BTW - If you are testing Edge / IE11 locally on a Mac, I can highly recommend
Parallels
. I had previously been debugging using a Win10 VM on VirtualBox, and it was pretty painful/slow. Currently using the the demo of Parallels Desktop and it's super fast. One thing, in case it saves you some time, if you want to run storybook on the host and open it in your VM you will need to run the following from privileged command line on VM:For VirtualBox:
For Parallels: