Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios 11.3 not supported #413

Closed
watlandc opened this issue Mar 31, 2018 · 7 comments · Fixed by #416
Closed

ios 11.3 not supported #413

watlandc opened this issue Mar 31, 2018 · 7 comments · Fixed by #416

Comments

@watlandc
Copy link

watlandc commented Mar 31, 2018

Bug or feature request?

Bug

Expected behavior

Drag and drop works beautifully as usual.

Actual behavior

With the upgrade to ios 11.3, drag and drop is not beautiful. When attempting to select and drag, the page now scrolls making it almost impossible to move an item.

Steps to reproduce

Upgrade to ios 11.3 and attempt to drag and drop.

Browser version

Tried Chrome 65.0.3325.152 and whatever Safari version ios 11.3 ships with (Safari 11).

Demo

Tested on our app and alsoreact-beautiful-dnd mobile examples provided (show in video below):

react_beautiful_dnd_ios_11 3

Thanks for your work on this excellent library!

@alexreardon
Copy link
Collaborator

alexreardon commented Mar 31, 2018 via email

@alexreardon
Copy link
Collaborator

I took a good crack at this tonight. It looks like safari has jumped to passive events by default - but not in the same way that chrome did a while back. This has been super painful to go through. I have a few ideas on how to work around it but it will take some time

@alexreardon
Copy link
Collaborator

I will continue my search on tuesday

@alexreardon
Copy link
Collaborator

I am really angry about safari doing this. I have wasted a lot of time this holiday weekend thinking about the problem. I am continuing my investigations tomorrow

@alexreardon
Copy link
Collaborator

Observation so far:

Sometimes event handlers add their own event handlers in response to an event. For example, we add a touchmove handler to the window after a touchstart. These dynamically added event handlers are unable to call event.preventDefault() even if they are non-passive event handlers in Safari 11.3. They still get the event, but the events are non-cancelable. A stand alone solution is providing difficult. I think there might be a micro-task timing issue going on

@jakeNiemiec
Copy link

Eagerly watching this issue in order to fix my own implementation.

@alexreardon
Copy link
Collaborator

alexreardon commented Apr 3, 2018

I have created a bug report with webkit (Please assist if you can)

I am also working on a fix (a huge hack) to get things working again on iOS 11.3 in the short term

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants