Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal based drag broken with touch #1604

Closed
TrySound opened this issue Nov 13, 2019 · 19 comments
Closed

Portal based drag broken with touch #1604

TrySound opened this issue Nov 13, 2019 · 19 comments

Comments

@TrySound
Copy link
Contributor

TrySound commented Nov 13, 2019

Common issues setup guide

https://react-beautiful-dnd.netlify.com/?path=/story/board--dragging-a-clone

Check your console

All clear

Are you new to rbd?

I'm an old one

Duplicates

I believe similar behaviour was before portals fix.

Expected behavior

Actual behavior

Kapture 2019-11-14 at 1 15 53

Steps to reproduce

Run devtools in mobile mode. I use iphone 5

What version of React are you using?

16.9

What version of react-beautiful-dnd are you running?

12.0.0

What browser are you using?

Chrome, safari ios

Demo

https://react-beautiful-dnd.netlify.com/?path=/story/board--dragging-a-clone

@alexreardon
Copy link
Collaborator

Try loading it out of the iframe and see what happens

@alexreardon
Copy link
Collaborator

Screen Shot 2019-11-14 at 9 21 39 am

Try the little expand button

@TrySound
Copy link
Contributor Author

Same

@alexreardon
Copy link
Collaborator

I just tested it on my iOS device (latest OS) and it seems to be working correctly. What version of safari / iOS are you using?

@alexreardon
Copy link
Collaborator

alexreardon commented Nov 13, 2019

I think safari made some changes to mobile stuff in the last update which did impact mobile a bit

@TrySound
Copy link
Contributor Author

I use simulator with iOS 13.1 and chrome devtools with touch mode. Though in simulator the problem look differently

Kapture 2019-11-14 at 1 29 37

@alexreardon
Copy link
Collaborator

alexreardon commented Nov 13, 2019 via email

@TrySound
Copy link
Contributor Author

My boss got it on his iPhone in production

@TrySound
Copy link
Contributor Author

Will try to provide better reproduce

@alexreardon
Copy link
Collaborator

alexreardon commented Nov 13, 2019 via email

@TrySound
Copy link
Contributor Author

TrySound commented Nov 18, 2019

@alexreardon My tester has these glitches on her iPhone with the latest safari version.
https://vimeo.com/373931892

@alexreardon
Copy link
Collaborator

Hey @TrySound, it feels like we are getting closer!

Can I confirm what version of iOS is being run?

@alexreardon
Copy link
Collaborator

alexreardon commented Nov 18, 2019

Interesting! Can you please open it up out of the iframe and confirm the issue is still occurring?

@TrySound
Copy link
Contributor Author

Looks like the problem is iframe. Now even simulator stopped glitching. Don't know the reason. Thanks :)

@alexreardon
Copy link
Collaborator

I’m super glad it is all good!

@jankuss
Copy link

jankuss commented Dec 5, 2019

I'm still having the same issue.

This is broken for example:
https://react-beautiful-dnd.netlify.com/iframe.html?id=portals--using-your-own-portal&viewMode=story

I use Chrome in the Touch Simulation mode. The touchstart on the Draggable element is recognized and is transitioned into the dragging state and moved into a portal. Subsequent touchmove events on the other hand don't seem to be recognized. It seems the touchend event is not being recognized aswell, as when I release the draggable it is still stuck in the dragging state.

When the Draggable is stuck in this state and I touchstart it again, everything works fine.

ezgif-4-30bf966d0fb1

@Merynek
Copy link

Merynek commented Mar 12, 2021

Why is this issue closed???
You can reproduce this issue in your own example so why closed??
Just open your examle with portal on your mobile and try dragging.
It is works only when you touch twice so it doesnt fixed.

https://react-beautiful-dnd.netlify.app/iframe.html?id=portals--using-your-own-portal&viewMode=story

@DavGarcia
Copy link

I had the same issue, but with react-dnd and react-dnd-touch-backend. I wonder if the issue is caused by some change in browser touch behavior or iOS rather than a library issue? Anyone find a fix?

@Merynek
Copy link

Merynek commented Apr 1, 2021

No the problem is in library, bcs I found the commit what caused it.
This issue: #2111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants