Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: external referenced schema names #1064

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DanielRamosAcosta
Copy link

This PR just adds a test for reproducing the error in #1063

I would like to fix it, but I'm not sure where is the error, I would need guidance here.

Copy link

changeset-bot bot commented Nov 17, 2024

⚠️ No Changeset found

Latest commit: 8f686f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

const onUserLoggedChannel = channels[1]
const userRegisteredMessagePayload = onUserRegisteredChannel.messages().all()[0].payload()?.json() as any;
const userLoggedMessagePayload = onUserLoggedChannel.messages().all()[0].payload()?.json() as any;
expect(userRegisteredMessagePayload?.["x-parser-schema-id"]).toBe("UserRegistered");
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails. The actual value is <anonymous-schema-1>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant